alamb commented on code in PR #19930:
URL: https://github.com/apache/datafusion/pull/19930#discussion_r2779330727
##########
datafusion/sql/tests/common/mod.rs:
##########
@@ -161,12 +161,26 @@ impl ContextProvider for MockContextProvider {
])),
"orders" => Ok(Schema::new(vec![
Field::new("order_id", DataType::UInt32, false),
+ Field::new("o_orderkey", DataType::UInt32, false),
+ Field::new("o_custkey", DataType::UInt32, false),
+ Field::new("o_orderstatus", DataType::Utf8, false),
Field::new("customer_id", DataType::UInt32, false),
+ Field::new("o_totalprice", DataType::Decimal32(15, 2), false),
Field::new("o_item_id", DataType::Utf8, false),
Field::new("qty", DataType::Int32, false),
Field::new("price", DataType::Float64, false),
Field::new("delivered", DataType::Boolean, false),
])),
+ "customer" => Ok(Schema::new(vec![
+ Field::new("c_custkey", DataType::UInt32, false),
+ Field::new("c_name", DataType::Utf8, false),
+ Field::new("c_address", DataType::Utf8, false),
+ Field::new("c_nationkey", DataType::UInt32, false),
+ Field::new("c_phone", DataType::Decimal32(15, 2), false),
Review Comment:
c_phone is utf8 --
https://github.com/apache/datafusion/blob/badaa8400d3a5bf4f27496dd377a2c3a2286908f/benchmarks/src/tpch/mod.rs#L86
##########
datafusion/sql/tests/common/mod.rs:
##########
@@ -161,12 +161,26 @@ impl ContextProvider for MockContextProvider {
])),
"orders" => Ok(Schema::new(vec![
Field::new("order_id", DataType::UInt32, false),
+ Field::new("o_orderkey", DataType::UInt32, false),
+ Field::new("o_custkey", DataType::UInt32, false),
+ Field::new("o_orderstatus", DataType::Utf8, false),
Field::new("customer_id", DataType::UInt32, false),
+ Field::new("o_totalprice", DataType::Decimal32(15, 2), false),
Review Comment:
Decimal32 is not consistent with the other schemas which use Decimal 128
https://github.com/apache/datafusion/blob/main/benchmarks/src/tpch/mod.rs#L81-L110
I'll fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
