nuno-faria commented on code in PR #1348:
URL: 
https://github.com/apache/datafusion-python/pull/1348#discussion_r2779560244


##########
python/datafusion/functions.py:
##########


Review Comment:
   This example also needs to be changed right?



##########
python/datafusion/functions.py:
##########


Review Comment:
   Should the same type of clarification be done on `last_value` as well?



##########
python/datafusion/functions.py:
##########


Review Comment:
   Similar example as the `first_value` one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to