askalt commented on code in PR #20222:
URL: https://github.com/apache/datafusion/pull/20222#discussion_r2781893284
##########
datafusion/ffi/src/udtf.rs:
##########
@@ -43,11 +45,18 @@ use crate::{df_result, rresult_return};
#[repr(C)]
#[derive(Debug, StableAbi)]
pub struct FFI_TableFunction {
- /// Equivalent to the `call` function of the TableFunctionImpl.
+ /// Equivalent to the [`TableFunctionImpl::call`].
/// The arguments are Expr passed as protobuf encoded bytes.
pub call:
unsafe extern "C" fn(udtf: &Self, args: RVec<u8>) ->
FFIResult<FFI_TableProvider>,
+ /// Equivalent to the [`TableFunctionImpl::call_with_args`].
+ call_with_args: unsafe extern "C" fn(
Review Comment:
There is `FFI_SessionRef` argument, which is `pub(crate)`, it was `pub`
recently, prior to https://github.com/apache/datafusion/pull/19281, so I
decided to leave `FFI_SessionRef` as `pub(crate)` as is and if `FFI_SessionRef`
will be exported sometime, then author could export this function too if need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
