alamb opened a new issue, #20240: URL: https://github.com/apache/datafusion/issues/20240
### Is your feature request related to a problem or challenge? - Part of https://github.com/apache/datafusion/issues/5483 We are adding support (slowly) for more sophisticated types of subqueries. Part of that is to ensure we have sufficient test coverage. ### Describe the solution you'd like I would like to make sure we have adequate coverage for subqueries (perhaps by porting) the tests from the duckdb repo to the Datafusion repo I expect some non trivial number of tests to fail at first ### Describe alternatives you've considered Here are some examples of correlated subquery tests from the duckdb repo - https://github.com/duckdb/duckdb/blob/main/test/sql/subquery/scalar/test_nested_correlated_subquery.test_slow - https://github.com/duckdb/duckdb/blob/main/test/sql/subquery/scalar/test_complex_nested_correlated_subquery.test - https://github.com/duckdb/duckdb/blob/main/test/sql/subquery/scalar/nested_subquery_window.test - https://github.com/duckdb/duckdb/blob/main/test/sql/subquery/table/test_nested_table_subquery.test_slow - https://github.com/duckdb/duckdb/blob/main/test/sql/subquery/complex/nested_correlated_list.test_slow - https://github.com/duckdb/duckdb/blob/main/test/sql/subquery/complex/nested_unnest_subquery.test - https://github.com/duckdb/duckdb/blob/main/test/sql/subquery/scalar/test_scalar_subquery.test - https://github.com/duckdb/duckdb/blob/main/test/sql/subquery/scalar/test_scalar_subquery_cte.test I suggest for each of these tests: 1. Porting them over to the datafusion repo (with a link back to their origin) 2. Any tests that now fail to run, add in comments the expected results (from duckdb) For example, if this query doesn't work ```sql query II SELECT i, (SELECT (SELECT (SELECT (SELECT 42+i1.i)++i1.i)+42+i1.i)+42+i1.i) AS j FROM integers i1 ORDER BY i; ---- NULL NULL 1 130 2 134 3 138 ``` Let's add something like ```sql # Expected Results # reference https://github.com/duckdb/duckdb/blob/324ff8c45f43478e09b6168f75a291b8d43ec3ee/test/sql/subquery/scalar/test_nested_correlated_subquery.test_slow#L29-L32 # ---- # NULL NULL # 1 130 # 2 134 # 3 138 errror query II SELECT i, (SELECT (SELECT (SELECT (SELECT 42+i1.i)++i1.i)+42+i1.i)+42+i1.i) AS j FROM integers i1 ORDER BY i; ---- Can't plan query... ``` ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
