adriangb commented on code in PR #20237:
URL: https://github.com/apache/datafusion/pull/20237#discussion_r2783399378
##########
datafusion/sqllogictest/test_files/projection_pushdown.slt:
##########
@@ -969,10 +968,9 @@ query TT
EXPLAIN SELECT s['value'] + s['value'] as doubled FROM simple_struct WHERE id
> 2;
----
logical_plan
-01)Projection: __common_expr_1 + __common_expr_1 AS doubled
-02)--Projection: get_field(simple_struct.s, Utf8("value")) AS __common_expr_1
-03)----Filter: simple_struct.id > Int64(2)
-04)------TableScan: simple_struct projection=[id, s],
partial_filters=[simple_struct.id > Int64(2)]
+01)Projection: get_field(simple_struct.s, Utf8("value")) +
get_field(simple_struct.s, Utf8("value")) AS doubled
Review Comment:
yep the intuition is that there's no point in de-duplicating `get_field`
because it's so trivial to compute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
