alamb commented on code in PR #20245:
URL: https://github.com/apache/datafusion/pull/20245#discussion_r2784251382
##########
datafusion/physical-optimizer/src/enforce_sorting/sort_pushdown.rs:
##########
@@ -355,6 +356,10 @@ fn pushdown_requirement_to_children(
}
} else if maintains_input_order.is_empty()
|| !maintains_input_order.iter().any(|o| *o)
+ // Aggregate output columns can be computed expressions that are not
Review Comment:
I am not convinced this is the best solution / correct yet -- i need to
understand it more fully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
