martin-g commented on code in PR #20243:
URL: https://github.com/apache/datafusion/pull/20243#discussion_r2788028130
##########
datafusion/functions-nested/src/set_ops.rs:
##########
@@ -184,11 +184,17 @@ impl ScalarUDFImpl for ArrayUnion {
)
)]
#[derive(Debug, PartialEq, Eq, Hash)]
-pub(super) struct ArrayIntersect {
+pub struct ArrayIntersect {
Review Comment:
This is now public to be able to use it in the benchmark test (a separate
crate).
Maybe annotate it with `#[doc(hidden)]` to hide it from the end users, since
it is not really supposed to be part of the public APIs ?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
