comphead commented on code in PR #3462:
URL: https://github.com/apache/datafusion-comet/pull/3462#discussion_r2789020838
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1181,6 +1181,21 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
// Test with pattern at end
val queryEnd = sql(s"select id from $table where contains (name,
'Smith')")
checkSparkAnswerAndOperator(queryEnd)
+
+ // Test with null haystack
+ sql(s"insert into $table values(6, null)")
+ checkSparkAnswerAndOperator(sql(s"select id, contains(name, 'Rose') from
$table"))
+
+ // Test case sensitivity (should not match)
+ checkSparkAnswerAndOperator(sql(s"select id from $table where
contains(name, 'james')"))
+ }
+ }
+
+ test("contains with both columns") {
Review Comment:
are you planning also move it to `sql` tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
