comphead opened a new pull request, #3474: URL: https://github.com/apache/datafusion-comet/pull/3474
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #. ## Rationale for this change When new PR is created it might start duplicated CI checks like in https://github.com/apache/datafusion-comet/pull/3470 <img width="700" height="65" alt="image" src="https://github.com/user-attachments/assets/970877d4-eb15-414a-afad-22c9101335d6"; /> <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? ## Remove duplicate CI runs by disabling push triggers on PR workflows ### Problem Currently, workflows with both `push` and `pull_request` triggers run twice: 1. Once when you push commits to a branch (`push` event) 2. Again when the PR is created/updated (`pull_request` event) This causes: - **Doubled CI resource usage** - Same tests run twice unnecessarily - **Confusing status checks** - Multiple check runs for the same commit - **Longer queue times** - Duplicate jobs compete for runner capacity - **Wasted developer time** - Waiting for redundant test results ### Solution Comment out `push` triggers in PR-focused workflows, keeping only `pull_request`: - ✅ `pr_build_linux.yml` - ✅ `pr_build_macos.yml` - ✅ `iceberg_spark_test.yml` - ✅ `spark_sql_test.yml` - ✅ `pr_benchmark_check.yml` - ✅ `miri.yml` - ✅ `validate_workflows.yml` ### Why pull_request is sufficient The `pull_request` trigger runs when: - A PR is opened - New commits are pushed to the PR branch - The PR is synchronized/updated This covers all the validation needed before merging. Direct pushes to feature branches don't need separate CI runs since they'll be tested when the PR is created/updated. ### Manual override still available All workflows retain `workflow_dispatch` for manual triggering when needed. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
