Acfboy commented on code in PR #20241:
URL: https://github.com/apache/datafusion/pull/20241#discussion_r2791131946
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -470,7 +470,7 @@ fn bitwise_coercion(left_type: &DataType, right_type:
&DataType) -> Option<DataT
return None;
}
- if left_type == right_type {
+ if left_type == right_type && left_type.is_integer() {
Review Comment:
```rust
let is_integer_dictionary =
matches!(left_type, Dictionary(_, value_type) if
value_type.is_integer());
if left_type == right_type && (left_type.is_integer() ||
is_integer_dictionary) {
return Some(left_type.clone());
}
```
I've added checks for Dictionary cases, the behavior remains consistent with
original version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
