adriangb commented on code in PR #20279:
URL: https://github.com/apache/datafusion/pull/20279#discussion_r2793195283
##########
datafusion/sqllogictest/test_files/dynamic_filter_pushdown_config.slt:
##########
@@ -288,6 +288,42 @@ physical_plan
04)------RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1
05)--------DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/dynamic_filter_pushdown_config/agg_data.parquet]]},
projection=[score], file_type=parquet, predicate=category@0 = alpha AND
DynamicFilter [ empty ], pruning_predicate=category_null_count@2 != row_count@3
AND category_min@0 <= alpha AND alpha <= category_max@1,
required_guarantees=[category in (alpha)]
+# Test 4b: Mixed aggregates with non MIN/MAX should not have DynamicFilter
+
+# Pure MAX — DynamicFilter is expected here as we can safely prune that don't
match the filter.
Review Comment:
I think there is already a test for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
