adriangb commented on issue #20214: URL: https://github.com/apache/datafusion/issues/20214#issuecomment-3884430809
> [@adriangb](https://github.com/adriangb) what do you think? Does this make sense, or am I missing some edge case? I am not sure, the combinations of the join types + null handling hurts my brain. My suggestion would be to add tests showing that the results are the same with and without dynamic filters, including tables with conflicting column names, etc. It's also worth looking at the logical filter pushdown optimizer rule which already deals with pushing filters through joins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
