andygrove opened a new pull request, #3487: URL: https://github.com/apache/datafusion-comet/pull/3487
## Summary - Make `CometSink.isFfiSafe` take the operator as a parameter so FFI safety can be determined per-scan - `CometScanWrapper.isFfiSafe` now returns `true` only for `CometScanExec` (native_iceberg_compat, which uses immutable Arrow readers after #3411), and `false` for `CometBatchScanExec` (Iceberg Java integration via SupportsComet, which still uses mutable buffers) - Remove stale `hasScanUsingMutableBuffers` check for `CometScanExec` since #3411 replaced mutable buffers with `ArrowConstantColumnReader` ## Test plan - [ ] Iceberg integration tests pass (triggered by `[iceberg]` in title) - [ ] Existing scan tests continue to pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
