andygrove commented on code in PR #3463: URL: https://github.com/apache/datafusion-comet/pull/3463#discussion_r2793858443
########## spark/src/test/resources/sql-tests/expressions/string/left.sql: ########## @@ -30,10 +30,36 @@ SELECT left(s, n) FROM test_str_left query SELECT left(s, 3) FROM test_str_left +-- column + literal: edge cases +query +SELECT left(s, 0) FROM test_str_left + +query +SELECT left(s, -1) FROM test_str_left + +query +SELECT left(s, 10) FROM test_str_left Review Comment: Thanks for the review @comphead. I added comments as requested. I'll merge this once CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
