neilconway commented on code in PR #20199:
URL: https://github.com/apache/datafusion/pull/20199#discussion_r2795487630
##########
datafusion/functions/src/unicode/substr.rs:
##########
@@ -247,19 +250,19 @@ pub fn enable_ascii_fast_path<'a, V: StringArrayType<'a>>(
// HACK: can be simplified if function has specialized
// implementation for `ScalarValue` (implement without
`make_scalar_function()`)
- let avg_prefix_len = start
+ let total_prefix_len = start
Review Comment:
Good point, in theory it might be a bit slower. I adjusted the code to use
`saturating_add` instead, which should be fine semantically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
