devanshu0987 commented on PR #20180: URL: https://github.com/apache/datafusion/pull/20180#issuecomment-3888494062
> I think we can implement `simplify` for `sum` > > https://github.com/apache/datafusion/blob/35ff4ab0a03fcc6615876eac76bac19887059ab3/datafusion/expr/src/udaf.rs#L682-L684 > > , just like in #18837; it should be simpler that way. Hi, is this a blocking PR review comment? I am not able to understand how it would be simpler? I am thinking that we still have the same logical flow - Detect the pattern of SUM(col + literal) - Modify the plan appropriately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
