kosiew commented on code in PR #20191:
URL: https://github.com/apache/datafusion/pull/20191#discussion_r2796949715
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -977,6 +977,14 @@ pub(crate) fn apply_join_filter_to_indices(
))
}
+/// Creates a [RecordBatch] with zero columns but the given row count.
+/// Used when a join has an empty projection (e.g. `SELECT count(1) ...`).
+fn new_empty_schema_batch(schema: &Schema, row_count: usize) -> RecordBatch {
+ let options = RecordBatchOptions::new().with_row_count(Some(row_count));
+ RecordBatch::try_new_with_options(Arc::new(schema.clone()), vec![],
&options)
+ .expect("empty schema batch construction should not fail")
Review Comment:
Could this return `Result<RecordBatch>` and propagate errors instead?
This keeps execution-plan code panic-free and consistent with surrounding
fallible batch construction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
