adriangb commented on PR #20192: URL: https://github.com/apache/datafusion/pull/20192#issuecomment-3891095920
> I don't think it is so helpful for projectionexec/filterexec as in those call sites, the checker runs before expr remap, so the indices are wrong, and the remap would mean we only care about column names anyway I wonder if we should integrate the remap into the index checker: something like check that all of the columns in the expression refer to one child by index, then remap all of the indexes to those of the child. > And i dont think these places can have duplicate names, unlike a join. Yes that's right. But it would still be nice if everything shares codepaths as much as possible (i.e. if the codepath can handle 2 inputs it should also work for 1). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
