neilconway commented on code in PR #20250:
URL: https://github.com/apache/datafusion/pull/20250#discussion_r2799175090
##########
datafusion/substrait/src/lib.rs:
##########
@@ -20,10 +20,6 @@
html_favicon_url =
"https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg";
)]
#![cfg_attr(docsrs, feature(doc_cfg))]
-// Make sure fast / cheap clones on Arc are explicit:
-// https://github.com/apache/datafusion/issues/11143
-#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
-#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
Review Comment:
Did you intend to remove `allow(clippy::needless_pass_by_value)` here?
##########
datafusion-cli/examples/cli-session-context.rs:
##########
@@ -73,8 +73,8 @@ impl CliSessionContext for MyUnionerContext {
&self,
plan: LogicalPlan,
) -> Result<DataFrame, DataFusionError> {
- let new_plan = LogicalPlanBuilder::from(plan.clone())
- .union(plan.clone())?
+ let new_plan = LogicalPlanBuilder::from(Arc::clone(&plan))
Review Comment:
`plan` is not an ARC?
##########
datafusion-cli/src/main.rs:
##########
@@ -816,7 +819,7 @@ mod tests {
assert_eq!(
2,
- df.clone()
+ Arc::clone(&df)
Review Comment:
`df` is not an ARC?
##########
dev/depcheck/Cargo.toml:
##########
@@ -20,7 +20,7 @@
name = "depcheck"
edition = "2024"
-# See more keys and their definitions at
https://doc.rust-lang.org/cargo/reference/manifest.html
+[lints]\nworkspace = true\n\n# See more keys and their definitions at
https://doc.rust-lang.org/cargo/reference/manifest.html
Review Comment:
Literal `\n` characters seem unintentional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg"](https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg"){kind=link}