neilconway commented on code in PR #20323:
URL: https://github.com/apache/datafusion/pull/20323#discussion_r2800715636
##########
datafusion/functions-nested/src/position.rs:
##########
@@ -164,7 +164,6 @@ fn general_position_dispatch<O: OffsetSizeTrait>(args:
&[ArrayRef]) -> Result<Ar
let arr_from = if args.len() == 3 {
as_int64_array(&args[2])?
.values()
- .to_vec()
Review Comment:
This change is not strictly related, but seems harmless and a clear win.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]