andygrove commented on PR #3500: URL: https://github.com/apache/datafusion-comet/pull/3500#issuecomment-3893092573
## CI Failure Comparison: PR #3500 (post-fix) vs df52 base (#3470) This compares the latest CI run of PR #3500 (commit `98bae1c2e`, with the ParquetFieldIdIOSuite fix) against the latest df52 branch CI (#3470). ### Improvements in PR #3500 vs df52 base | Test Suite | df52 (#3470) | PR #3500 | Notes | |---|---|---|---| | **`ParquetV1SchemaPruningSuite`** | 3 jobs FAIL (44 failures each) | **ALL PASS** | Fixed by this PR's schema pruning changes | | **`SQLQueryTestSuite`** | 2 jobs FAIL | **ALL PASS** | Fixed by this PR | | **`sql_core-2` (all configs)** | 4/4 FAIL | **4/4 PASS** | All passing now | ### Pending (still running) | Check | Status | Notes | |---|---|---| | `sql_core-1` (all Spark versions) | IN_PROGRESS | Will confirm if `ParquetFieldIdIOSuite` fix works | | `sql_core-3`, `sql_hive-1` | IN_PROGRESS | | ### Same failures on both PRs (pre-existing on df52) | Failure | Jobs | Root Cause | Tracked In | |---|---|---|---| | Scalafix unused import (`CometExprShim.scala:32`) | All Spark 4.0 jobs (14 jobs) | Unused imports in Spark 4.0 shim | Needs fix in df52 | | `select column with default value` | native_datafusion fuzz (2 tests) | Native c2r returns null instead of default | #3482 | | Miri build failure | All branches | Stale toolchain cache | #3499, fix in #3504 | ### Summary The schema pruning fix in this PR resolves **48+ test failures** (`ParquetV1SchemaPruningSuite` + `SQLQueryTestSuite`) that exist on the df52 base branch. The `sql_core-1` jobs are still running and will confirm whether the `ParquetFieldIdIOSuite` regression (from the previous commit) has been fixed by the fallback guard added in commit `98bae1c2e`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
