Omega359 commented on PR #20308: URL: https://github.com/apache/datafusion/pull/20308#issuecomment-3897886637
> cc @Omega359 @comphead did we ever land on a consensus regarding `regexp_extract` and `regexp_substr`? We had some PRs for them before and they seemed to lapse, but looks like there was still some discussion on which regex functions we include as part of datafusion The last I recall thinking about this was summarized in [this comment](https://github.com/apache/datafusion/pull/14282#issuecomment-2773275754). The functions, at least as can be seen in other db's or query engines, are very similar with extract being slightly more powerful by allowing one to define which group to extract. Frankly, I could see datafusion having one function that does both (aliased to regexp_substr and regexp_extract) where an optional 'index' or 'group' can be provided (defaulting to 0) that denotes which capture group to return. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
