alamb commented on PR #11453: URL: https://github.com/apache/datafusion/pull/11453#issuecomment-2227384094
> @alamb (I don't know who else to ask for help) > > I have no idea how to fix the tests. The issue seems to stem from sqllogictests + backtrace feature. > > minimal command: `RUST_BACKTRACE=1 cargo test --features backtrace --tests` > > Adding the `--release` flag seems to solve the issue. Skipping sqllogictests also doesn't raise an issue. > > Does SQLParser 0.48 have some massive struct on the stack that needs to be boxed and isn't cleaned in debug mode? Why does it pass if backtrace feature isn't enabled or when sqllogictests are skipped? Thanks @MohamedAbdeen21 I don't know why the `--features backtrace` is causing issues. Maybe @comphead had some idea I think you are likely right that something in sqlparser has grown the stack space slightly so now we are hitting stack overflows. Maybe if we can find what exactly is on the stack when it overflows we can refactor datafusion (e.g. break a single large function into multiple smaller ones) to work around the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
