cj-zhukov commented on PR #20366: URL: https://github.com/apache/datafusion/pull/20366#issuecomment-3903865617
### High-Level Overview This PR refactors the three percentile functions: - `percentile_cont` - `approx_percentile_cont` - `approx_percentile_cont_with_weight` Changes: - Removed `Sort` from the function signatures - Replaced it with a simpler interface that accepts: `expr` and `asc` - Constructed `Sort` internally within each function - Set `nulls_first = false` internally, since percentile calculations ignore null values and null ordering has no semantic effect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
