nuno-faria commented on code in PR #20047:
URL: https://github.com/apache/datafusion/pull/20047#discussion_r2809240718
##########
datafusion-cli/src/main.rs:
##########
@@ -647,9 +644,9 @@ mod tests {
+-----------------------------------+-----------------+---------------------+------+------------------+
| filename | file_size_bytes |
metadata_size_bytes | hits | extra |
+-----------------------------------+-----------------+---------------------+------+------------------+
- | alltypes_plain.parquet | 1851 | 8882
| 5 | page_index=false |
+ | alltypes_plain.parquet | 1851 | 8882
| 8 | page_index=false |
| alltypes_tiny_pages.parquet | 454233 | 269266
| 2 | page_index=true |
- | lz4_raw_compressed_larger.parquet | 380836 | 1347
| 3 | page_index=false |
+ | lz4_raw_compressed_larger.parquet | 380836 | 1347
| 4 | page_index=false |
+-----------------------------------+-----------------+---------------------+------+------------------+
Review Comment:
It appears that the ordering is retrieved each time because the files
statistics cache is missing in the `ListingTable`. `collected_statistics` is
now `None`, while before it was assigned a cache:
https://github.com/apache/datafusion/blob/53b0ffb93d5fb662506439b6f1ffc34f2d7684ec/datafusion/catalog-listing/src/table.rs#L235
I'm not too familiar with this, but shouldn't the session cache be passed
to `ListingTable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
