alamb commented on code in PR #11458: URL: https://github.com/apache/datafusion/pull/11458#discussion_r1677158635
########## datafusion/physical-expr-common/src/aggregate/mod.rs: ########## @@ -43,6 +43,9 @@ use datafusion_expr::utils::AggregateOrderSensitivity; /// Creates a physical expression of the UDAF, that includes all necessary type coercion. /// This function errors when `args`' can't be coerced to a valid argument type of the UDAF. +/// +/// `input_exprs` and `sort_exprs` are used for customizing Accumulator as the arguments in `AccumulatorArgs`, Review Comment: ```suggestion /// `input_exprs` and `sort_exprs` are used for customizing Accumulatorsz /// whose behavior depends on arguments such as a an `ORDER BY`. /// /// For example to call `ARRAY_AGG(x ORDER BY y)` would pass `[y]` /// `sort_exprs` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
