timsaucer commented on code in PR #1382:
URL:
https://github.com/apache/datafusion-python/pull/1382#discussion_r2817721344
##########
python/tests/test_functions.py:
##########
@@ -772,6 +772,14 @@ def test_array_function_obj_tests(stmt, py_expr):
f.regexp_count(column("a"), literal("(ell|orl)"), literal(1)),
pa.array([1, 1, 0], type=pa.int64()),
),
+ (
+ f.regexp_instr(column("a"), literal("(ell|orl)")),
+ pa.array([2, 2, 0], type=pa.int64()),
+ ),
+ (
+ f.regexp_instr(column("a"), literal("([lr])"), n=literal(2)),
+ pa.array([4, 4, 0], type=pa.int64()),
+ ),
],
Review Comment:
I recommend adding in tests for all options. I don't expect problems here
but it's come up in the past to make sure there are no mistakes along the path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
