Dandandan commented on issue #20324: URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3915572132
Thinking about it a bit more: `SELECT "SearchPhrase" FROM hits WHERE "SearchPhrase" <> '' ORDER BY "EventTime" LIMIT 10;` Is query 24 (with 2 columns) in general it makes no sense to push down 2 columns. When having as much rowfilters as projected columns, it is always better to drop the final row filter (as it will not filter out more than already scanned). @notashes does that make sense, could you simplify your PR https://github.com/apache/datafusion/pull/20413 to do this instead (it will also end up using the dynamic filter as the column is smaller)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
