neilconway commented on code in PR #20328:
URL: https://github.com/apache/datafusion/pull/20328#discussion_r2818118920
##########
datafusion/functions/benches/trim.rs:
##########
@@ -221,6 +260,57 @@ fn run_trim_benchmark(
group.finish();
}
+#[expect(clippy::too_many_arguments)]
+fn run_space_trim_benchmark(
+ c: &mut Criterion,
+ group_name: &str,
+ trim_func: &ScalarUDF,
+ trim_type: TrimType,
+ string_types: &[StringArrayType],
+ size: usize,
+ pad_len: usize,
+ remaining_len: usize,
+) {
+ let mut group = c.benchmark_group(group_name);
+ group.sampling_mode(SamplingMode::Flat);
+ group.sample_size(10);
+
+ let total_len = pad_len + remaining_len;
Review Comment:
Good catch! It only applies to the benchmark label text but worth fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
