andygrove commented on code in PR #3544:
URL: https://github.com/apache/datafusion-comet/pull/3544#discussion_r2818948744
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -960,44 +960,40 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
// CAST from DateType
- ignore("cast DateType to BooleanType") {
- // Arrow error: Cast error: Casting from Date32 to Boolean not supported
- castTest(generateDates(), DataTypes.BooleanType)
+ test("cast DateType to BooleanType") {
+ castTest(generateDates(), DataTypes.BooleanType, testAnsi = false, testTry
= false)
Review Comment:
Could you add comments explaining why these tests disable `testAnsi` and
`testTry`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
