andygrove commented on PR #3497: URL: https://github.com/apache/datafusion-comet/pull/3497#issuecomment-3926233766
Thanks for the contribution @rafafrdz. I took a quick look and this looks nice. I kicked off CI. On the testing side, the current tests only cover GCM mode with a 256-bit key. Since the Rust implementation also supports CBC and ECB modes with PKCS padding, and handles 128-bit, 192-bit, and 256-bit keys, it would be great to add test coverage for those combinations. It might also be worth adding a null input test, maybe inserting a row with null encrypted data and verifying the result is null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
