jayzhan211 commented on code in PR #11461:
URL: https://github.com/apache/datafusion/pull/11461#discussion_r1677402668
##########
datafusion/functions/src/core/map.rs:
##########
@@ -28,7 +28,22 @@ use datafusion_common::{exec_err, internal_err, ScalarValue};
use datafusion_common::{not_impl_err, Result};
use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility};
+/// Check if we can evaluate the expr to constant directly.
+///
+/// # Example
+/// ```sql
+/// SELECT make_map('type', 'test') from test
+/// ```
+/// We can evaluate the result of `make_map` directly.
+#[inline]
Review Comment:
I think there is rare case for `inline`. I perfer not to inline unless the
benmark shows that compiler fail to do the good job for us
https://matklad.github.io/2021/07/09/inline-in-rust.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
