jonathanc-n commented on code in PR #20441:
URL: https://github.com/apache/datafusion/pull/20441#discussion_r2831526637
##########
datafusion/core/tests/sql/joins.rs:
##########
@@ -299,3 +299,52 @@ async fn unparse_cross_join() -> Result<()> {
Ok(())
}
+
+// Issue #20437: https://github.com/apache/datafusion/issues/20437
+#[tokio::test]
Review Comment:
We want to keep unit tests at a minimum when possible. Use sqllogictests
instead here
##########
datafusion/physical-plan/src/joins/hash_join/inlist_builder.rs:
##########
@@ -130,4 +133,41 @@ mod tests {
)
);
}
+
+ #[test]
+ fn test_build_multi_column_inlist_with_dictionary() {
+ let mut builder =
StringDictionaryBuilder::<arrow::datatypes::Int8Type>::new();
+ builder.append_value("foo");
+ builder.append_value("foo");
+ builder.append_value("foo");
+ let dict_array = Arc::new(builder.finish()) as ArrayRef;
+
+ let int_array = Arc::new(Int32Array::from(vec![1, 2, 3])) as ArrayRef;
+
+ let result = build_struct_inlist_values(&[dict_array, int_array])
+ .unwrap()
+ .unwrap();
+
+ assert_eq!(result.len(), 3);
+ assert_eq!(
+ *result.data_type(),
+ DataType::Struct(
+ build_struct_fields(&[DataType::Utf8,
DataType::Int32]).unwrap()
+ )
+ );
+ }
+
+ #[test]
+ fn test_build_single_column_dictionary_inlist() {
Review Comment:
I don't think this test is necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
