mbutrovich commented on code in PR #3555:
URL: https://github.com/apache/datafusion-comet/pull/3555#discussion_r2834779891
##########
spark/src/main/scala/org/apache/comet/CometExecIterator.scala:
##########
@@ -278,6 +278,11 @@ object CometExecIterator extends Logging {
builder.putEntries(k, v)
}
}
+ // Inject the resolved executor cores so the native side can use it
+ // for tokio runtime thread count
+ val executorCores = numDriverOrExecutorCores(SparkEnv.get.conf)
Review Comment:
What are the semantics of `numDriverOrExecutorCores`. It wasn't clear to me
from reading the implementation. From the function name, it sounds like it
might not always be `spark.executor.cores` depending on where it's invoked
(driver or executor).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
