davidlghellin opened a new pull request, #20461:
URL: https://github.com/apache/datafusion/pull/20461
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- NA.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Spark's `mod` and `pmod` functions return `NULL` on integer division by zero
in legacy mode (ANSI off), but DataFusion's implementation always threw a
`DivideByZero` error regardless of the ANSI mode setting.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Add ANSI mode support to `spark_mod` and `spark_pmod` via enable_ansi_mode
config option
In legacy mode (ANSI off): division by zero returns `NULL` per-element
In ANSI mode (ANSI on): division by zero throws an error (unchanged behavior)
Add `try_rem` helper that handles per-element zero-divisor masking for
integer arrays
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes:
- 18 unit tests in modulus.rs (including new tests for both ANSI modes)
- Updated pmod.slt and mod.slt sqllogictests with ANSI on/off coverage
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Yes — mod(10, 0) and pmod(10, 0) now return NULL instead of erroring when
enable_ansi_mode = false (the default), matching Spark behavior.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
