Jefffrey commented on code in PR #20479:
URL: https://github.com/apache/datafusion/pull/20479#discussion_r2838768616
##########
datafusion/spark/src/function/math/bin.rs:
##########
@@ -78,64 +79,57 @@ impl ScalarUDFImpl for BitmapBucketNumber {
) -> Result<FieldRef> {
Ok(Arc::new(Field::new(
self.name(),
- DataType::Int64,
+ DataType::Utf8,
args.arg_fields[0].is_nullable(),
)))
}
fn invoke_with_args(&self, args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
- make_scalar_function(bitmap_bucket_number_inner, vec![])(&args.args)
+ make_scalar_function(spark_bin_inner, vec![])(&args.args)
}
}
-pub fn bitmap_bucket_number_inner(arg: &[ArrayRef]) -> Result<ArrayRef> {
- let [array] = take_function_args("bitmap_bucket_number", arg)?;
+pub fn spark_bin_inner(arg: &[ArrayRef]) -> Result<ArrayRef> {
Review Comment:
```suggestion
fn spark_bin_inner(arg: &[ArrayRef]) -> Result<ArrayRef> {
```
Doesn't need to be pub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
