alamb commented on code in PR #19728:
URL: https://github.com/apache/datafusion/pull/19728#discussion_r2840853473
##########
datafusion/functions-nested/src/range.rs:
##########
@@ -392,20 +392,27 @@ impl Range {
}
let stop = if !self.include_upper_bound {
- Date32Type::subtract_month_day_nano(stop, step)
+ Date32Type::subtract_month_day_nano_opt(stop,
step).ok_or_else(|| {
Review Comment:
due to https://github.com/apache/arrow-rs/pull/9144 from @cht42 (the
underlying library now checks for overflow and returns None rather than
panic'ing)
##########
datafusion/sqllogictest/test_files/explain_tree.slt:
##########
@@ -268,7 +268,7 @@ physical_plan
06)┌─────────────┴─────────────┐
07)│ DataSourceExec │
08)│ -------------------- │
-09)│ bytes: 1040 │
+09)│ bytes: 1024 │
Review Comment:
the size of parquet files changes slightly from version to version (as the
embedded version changes, etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
