andygrove commented on PR #3563: URL: https://github.com/apache/datafusion-comet/pull/3563#issuecomment-3947725845
This looks good so far @rafafrdz. CI shows all three `parse_url` tests failing on Spark 4.0 with `COMET: invoke is not supported`. This happens because `ParseUrl` was changed to `RuntimeReplaceable` in Spark 4.0. It gets replaced by an `Invoke` expression during analysis, so Comet's serde never sees the `ParseUrl` node. On the compatibility side, I noticed that the PR doesn't distinguish between ANSI and legacy mode for invalid URL handling. DataFusion's `parse_url` throws errors on malformed URLs, which matches Spark's behavior when `failOnError=true` (ANSI mode), but in legacy mode (`failOnError=false`), Spark returns null for invalid URLs instead of throwing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
