martin-g commented on code in PR #20511:
URL: https://github.com/apache/datafusion/pull/20511#discussion_r2845561430
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -227,14 +242,38 @@ async fn run_tests() -> Result<()> {
)
.await?
}
+ };
+ // Log slow files (>30s) for CI debugging
+ let elapsed = file_start.elapsed();
+ if elapsed.as_secs() > 30 {
+ eprintln!(
+ "Slow file: {} took {:.1}s",
+ relative_path_for_timing.display(),
+ elapsed.as_secs_f64()
+ );
}
- Ok(()) as Result<()>
+ Ok(())
})
.join()
.map(move |result| (result, relative_path,
currently_running_sql_tracker))
})
// run up to num_cpus streams in parallel
.buffer_unordered(options.test_threads)
+ .inspect({
+ let completed_count = Arc::clone(&completed_count);
+ move |_| {
+ let completed = completed_count.fetch_add(1,
Ordering::Relaxed) + 1;
+ // In CI (no TTY), print progress every 10% or every 50 files
Review Comment:
```suggestion
// In CI (no TTY), print progress after every 50 files and
at the end
```
there is no logic for `every 10%`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
