andygrove opened a new pull request, #3583:
URL: https://github.com/apache/datafusion-comet/pull/3583

   ## Summary
   - Fixes native columnar-to-row conversion crash when Spark generates default 
column values with physical types (e.g. `Int32`) that differ from logical 
schema types (e.g. `Date32`)
   - Changes the fallback arm in `maybe_cast_to_schema_type` to attempt an 
Arrow cast for any type mismatch, rather than silently passing through the 
mismatched array
   - This prevents similar issues for other data types in the future
   
   ## Test plan
   - [x] Existing test `select column with default value` in 
`CometFuzzTestSuite` passes (previously failed with `CometNativeException: 
Failed to downcast to Date32Array, actual type: Int32`)
   - [x] `cargo clippy` clean
   - [x] Full `CometFuzzTestSuite` passes
   
   Closes #3482


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to