neilconway commented on PR #20532:
URL: https://github.com/apache/datafusion/pull/20532#issuecomment-3953821411
Benchmarks:
```
┌────────────────┬─────────┬─────────┬─────────────┐
│ Benchmark │ Before │ After │ Improvement │
├────────────────┼─────────┼─────────┼─────────────┤
│ found_once/10 │ 1.73 ms │ 55.6 µs │ -96.6% │
├────────────────┼─────────┼─────────┼─────────────┤
│ found_many/10 │ 1.61 ms │ 68.5 µs │ -95.5% │
├────────────────┼─────────┼─────────┼─────────────┤
│ not_found/10 │ 1.80 ms │ 47.0 µs │ -97.3% │
├────────────────┼─────────┼─────────┼─────────────┤
│ found_once/100 │ 1.90 ms │ 156 µs │ -91.2% │
├────────────────┼─────────┼─────────┼─────────────┤
│ found_many/100 │ 2.05 ms │ 459 µs │ -76.5% │
├────────────────┼─────────┼─────────┼─────────────┤
│ not_found/100 │ 2.13 ms │ 144 µs │ -93.2% │
├────────────────┼─────────┼─────────┼─────────────┤
│ found_once/500 │ 2.39 ms │ 586 µs │ -75.4% │
├────────────────┼─────────┼─────────┼─────────────┤
│ found_many/500 │ 2.68 ms │ 2.34 ms │ -12.8% │
├────────────────┼─────────┼─────────┼─────────────┤
│ not_found/500 │ 4.12 ms │ 585 µs │ -85.8% │
└────────────────┴─────────┴─────────┴─────────────┘
```
`found_many/500` is not surprising as a worst-case: the bitmap we get back
from `arrow_ord::cmp::not_distinct` is dense, so we aren't able to save much
work. But at least it's still a win.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
