mbutrovich opened a new pull request, #3584:
URL: https://github.com/apache/datafusion-comet/pull/3584
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
N/A.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The native Iceberg scan currently hardcodes `data_file_concurrency_limit` to
DataFusion's `target_partitions()`, which doesn't give users control over
per-task file read parallelism. For tables with many small files, increasing
concurrency overlaps I/O latency and improves throughput.
We tested this in #3551 and saw good speedup with a value of 4 in an object
store setting.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Adds `spark.comet.scan.icebergNative.dataFileConcurrencyLimit` config that
controls iceberg-rust's `ArrowReaderBuilder::with_data_file_concurrency_limit`.
The value is serialized through protobuf from the JVM to native. Defaults to 1
to preserve deterministic output ordering in tests that lack an explicit ORDER
BY.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
