alamb commented on code in PR #11440:
URL: https://github.com/apache/datafusion/pull/11440#discussion_r1678305488
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -303,8 +312,8 @@ impl BatchPartitioner {
let batch =
RecordBatch::try_new(batch.schema(),
columns).unwrap();
- // bind timer so it drops w/ this iterator
- let _ = &timer;
+ // Finished building repartitioned batches
+ timer.done();
Review Comment:
I wonder if this is needed now that `timer` is a local variable in the loop
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -282,6 +283,11 @@ impl BatchPartitioner {
.append_value(index as u64);
}
+ // Finished building index-arrays for output partitions
+ timer.done();
+
+ // Borowing partitioner timer to prevent moving `self` to
closure
Review Comment:
FYI there is a typo here (`Borrowing`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
