neilconway commented on code in PR #20504:
URL: https://github.com/apache/datafusion/pull/20504#discussion_r2866975396
##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -414,6 +435,296 @@ impl Accumulator for ArrayAggAccumulator {
}
}
+#[derive(Debug)]
+struct ArrayAggGroupsAccumulator {
Review Comment:
Sure -- I added another benchmark that uses a named struct over a dict,
which should hopefully approximate the workload in #17446 reasonably well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
