tshauck commented on PR #11371: URL: https://github.com/apache/datafusion/pull/11371#issuecomment-2229478589
I'm going to close this as I don't think it is necessary for count() though it seemed to be an incremental step towards supporting planned aggregate udf expressions. For `count()` I actually did try that in the first commit into this PR (https://github.com/apache/datafusion/pull/11229). I tried turning it into a plannable expression which resulted in this PR, but it ends up being quiet complex and has some reduced functionality w.r.t. the way the dataframe api works. I'm gonna revert that PR back to the original approach, though I may do so in a new PR to keep things cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
