Rafferty97 commented on PR #20604: URL: https://github.com/apache/datafusion/pull/20604#issuecomment-3979418213
Hey @Omega359, Maybe I'm missing something, but what is the actual advantage of returning a `Utf8View` from a UDF like reverse? For functions like `trim` or `substr` it makes sense to a `Utf8View` regardless of the input type, as it allows for reuse of the underlying string buffer, given that each output value is just a slice of existing string data. But for a function like `reverse` that creates brand new string values, surely returning `Utf8View` just adds extra overhead with no benefit? I'm happy to be corrected if there's something I'm misunderstanding here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
