Mark1626 commented on PR #20460: URL: https://github.com/apache/datafusion/pull/20460#issuecomment-3979814485
I've addressed the review comments. The `single_distinct_to_groupby.rs` optimizer rule throws an error for `select count(distinct c, c)` It's using a `HashSet` so `distinct c, c` is considered as a single column. I trying to see if something can be done for this https://github.com/apache/datafusion/blob/6713439497561fa74a94177e5b8632322fb7cea5/datafusion/optimizer/src/single_distinct_to_groupby.rs#L65-L67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
