jayzhan211 commented on issue #10782: URL: https://github.com/apache/datafusion/issues/10782#issuecomment-2229757379
The dependencies in core is quite complex, take a note for it Draft the dependency graph, incomplete ```mermaid graph TD; CatalogProvider --> TableProvider TableProvider --> SessionState TableProvider --> ExecutionPlan SessionState --> PhysicalOptimizer SessionState --> QueryPlanner QueryPlanner --> ExecutionPlan SessionState --> CatalogProviderList SessionState --> TableFunction SessionState --> FileFormatFactory SessionState --> SessionConfig SessionState --> TableProviderFactory SessionState --> RuntimeEnv SessionState --> FunctionFactory FunctionFactory --> TableProvider TableFunction --> TableProvider FileFormatFactory --> FileFormat FileFormat --> SessionState FileFormat --> ExecutionPlan PhysicalOptimizer --> PartitionedFile CatalogProviderList --> CatalogProvider ``` Circular found. It means they should be in the same crate ```mermaid graph TD; CatalogProvider --> TableProvider TableProvider --> SessionState SessionState --> TableFunction TableFunction --> TableProvider ``` ```mermaid graph TD; CatalogProvider --> TableProvider TableProvider --> SessionState SessionState --> CatalogProviderList CatalogProviderList --> CatalogProvider ``` ```mermaid graph TD; CatalogProvider --> TableProvider TableProvider --> SessionState SessionState --> FileFormatFactory FileFormatFactory --> FileFormat FileFormat --> SessionState ``` CatalogProvider + TableProvider + SessionsState + FileFormat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org