Acfboy opened a new pull request, #20638:
URL: https://github.com/apache/datafusion/pull/20638
…d in file formats
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #16944.
## Rationale for this change
Currently, the `LogicalExtensionCodec` implementation for
`DefaultLogicalExtensionCodec` leaves `try_decode_file_format` /
`try_encode_file_format` unimplemented (returning "not implemented" errors).
However, the actual serialization logic for built-in file formats — arrow,
parquet, csv, and json— already exists in their respective codec
implementations. All we need to do is tag which format is being used, and
delegate to the corresponding format-specific codec to handle the data.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Added a `FileFormatKind` enum and a `FileFormatProto` message to
`datafusion.proto` to identify the file format type during transmission.
Implemented `try_decode_file_format` and `try_encode_file_format` for
`DefaultLogicalExtensionCodec`, which dispatch serialization/deserialization to
the corresponding format-specific codec based on the format kind. Note that
Avro is not covered because the upstream repository has not yet implemented the
corresponding Avro codec, so Avro support is not functional at this time.
## Are these changes tested?
Yes. Roundtrip tests are included for csv, json, parquet, and arrow.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
