andygrove commented on code in PR #3615:
URL: https://github.com/apache/datafusion-comet/pull/3615#discussion_r2872948850
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -408,4 +408,50 @@ trait CommonStringExprs {
None
}
}
+
+ def hoursOfTimeToProto(
Review Comment:
It might make more sense to place `hoursOfTimeToProto` alongside the
existing `CometHour` handler in `datetime.scala`, since that's where the Hour
serde already lives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
